Broken PMC when rebasing on upstream
[govanify@alastor:~/Documents/projects/hardware/x2100/coreboot/coreboot-x2100]$ git bisect good
fd83e85eeb488d46418afdcc6100f38b594d6d3e is the first bad commit
commit fd83e85eeb488d46418afdcc6100f38b594d6d3e
Author: Tim Wawrzynczak <twawrzynczak@chromium.org>
Date: Thu Jul 1 08:41:48 2021 -0600
soc/intel/cannonlake: Switch PMC to use device callbacks
Now that the PMC device is marked as hidden in devicetrees, the device
callbacks can be used instead of BOOT_STATE_INIT_ENTRY callbacks.
Note that this moves PMC initialization from BS_DEV_INIT_CHIPS to
BS_DEV_ENUMERATE, which aligns with other Intel SoCs.
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Change-Id: If292728ad975ba803fed6abea879f6f634470a11
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56009
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
src/soc/intel/cannonlake/chip.c | 3 +++
src/soc/intel/cannonlake/include/soc/pmc.h | 4 +++
src/soc/intel/cannonlake/lpc.c | 17 ------------
src/soc/intel/cannonlake/pmc.c | 42 +++++++++++++++++++-----------
src/soc/intel/cannonlake/systemagent.c | 11 --------
5 files changed, 34 insertions(+), 43 deletions(-)